linux-kernel - Re: [PATCH] mm/gup: Clean up errors in gup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a65a8eb8-8889-051b-f46b-b797ed91e0b0@redhat.com>
Date:   Mon, 2 Oct 2023 13:15:34 +0200
From:   David Hildenbrand <david@...hat.com>
To:     KaiLong Wang <wangkailong@...i.cn>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/gup: Clean up errors in gup.c

On 28.09.23 05:28, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: else should follow close brace '}'
> 
> Signed-off-by: KaiLong Wang <wangkailong@...i.cn>
> ---
>   mm/gup.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 2f8a2d89fde1..aed327450250 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
>   			return -EAGAIN;
>   		must_unlock = true;
>   		*locked = 1;
> -	}
> -	else
> +	} else
>   		mmap_assert_locked(mm);
>   
>   	if (flags & FOLL_PIN)

Please see Documentation/process/coding-style.rst "3) Placing Braces and 
Spaces"

-- 
Cheers,

David / dhildenb