linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231002-unmolded-petition-d2ee6a725c31@spud>
Date:   Mon, 2 Oct 2023 12:16:59 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Luca Weiss <luca.weiss@...rphone.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused
 labels from examples

On Mon, Oct 02, 2023 at 09:00:11AM +0200, Luca Weiss wrote:
> There's not much point in having unused labels in the binding example,
> so drop them.
> 
> This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom:
> Use plural _gpios node label for PMIC gpios") updating all dts files to
> use the plural _gpios label instead of the singular _gpio as label but
> this example wasn't updated. But since we should just drop the label
> alltogether, do that.
> 
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 55e931ba5b47..9fa568603930 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -239,13 +239,13 @@ examples:
>          interrupt-controller;
>          #interrupt-cells = <4>;
>  
> -        pmi8998_lsid0: pmic@2 {
> +        pmic@2 {
>              compatible = "qcom,pmi8998", "qcom,spmi-pmic";
>              reg = <0x2 SPMI_USID>;
>              #address-cells = <1>;
>              #size-cells = <0>;
>  
> -            pmi8998_gpio: gpio@...0 {
> +            gpio@...0 {
>                  compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
>                  reg = <0xc000>;
>                  gpio-controller;
> @@ -330,7 +330,7 @@ examples:
>              };
>          };
>  
> -        pm6150_gpio: gpio@...0 {
> +        gpio@...0 {
>              compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio";
>              reg = <0xc000>;
>              gpio-controller;
> 
> -- 
> 2.42.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)