linux-kernel - Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231002140953.170c0055@xps-13>
Date:   Mon, 2 Oct 2023 14:09:53 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Martin Kurbanov <mmkurbanov@...utedevices.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Mario Kicherer <dev@...herer.org>,
        Chuanhong Guo <gch981213@...il.com>,
        Dhruva Gole <d-gole@...com>, <linux-kernel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <kernel@...rdevices.ru>
Subject: Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G

Hi Martin,

mmkurbanov@...utedevices.com wrote on Mon, 2 Oct 2023 13:18:18 +0300:

> Hi Miquel,
> Thanks for your review.
> 
> On 02.10.2023 12:44, Miquel Raynal wrote:
> > Hi Martin,  
> >> +static int f35sqa002g_ooblayout_free(struct mtd_info *mtd, int section,
> >> +				     struct mtd_oob_region *region)
> >> +{
> >> +	/* XXX: It is not possible to partially write to this OOB area, as both
> >> +	 * the main and OOB areas are protected by ECC. The user needs to
> >> +	 * program both the main area and OOB area at one programming time,
> >> +	 * so that the ECC parity code can be calculated properly.
> >> +	 */  
> > 
> > Is this comment really needed? I believe it could be dropped, unless
> > you are really experiencing strange subpage write attempts?  
> 
> If you write separately to the main area and the OOB area. This is the
> case with many SPI NAND chips, I agree that this comment can be dropped.
> 

All NAND chips have this limitation actually. I guess you can just get
rid of the comment. The rest looks ok.

Thanks, Miquèl