[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iJqFC-Z3NZwT+CXEG7R9rc9g4LRwNm6Zm=nZKpD3Mon7Q@mail.gmail.com>
Date: Mon, 2 Oct 2023 14:35:22 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Vincent Whitchurch <vincent.whitchurch@...s.com>,
Raju Rangoju <rajur@...lsio.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Ping-Ke Shih <pkshih@...ltek.com>,
Kalle Valo <kvalo@...nel.org>, Simon Horman <horms@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jiri Pirko <jiri@...nulli.us>,
Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-wireless@...r.kernel.org
Subject: Re: [net-next PATCH 1/3] net: introduce napi_is_scheduled helper
On Mon, Oct 2, 2023 at 2:29 PM Christian Marangi <ansuelsmth@...il.com> wrote:
> Ehhh the idea here was to reduce code duplication since the very same
> test will be done in stmmac. So I guess this code cleanup is a NACK and
> I have to duplicate the test in the stmmac driver.
I simply wanted to add a comment in front of this function/helper,
advising not using it unless absolutely needed.
Thus my question "In which context is it safe to call this helper ?"
As long as it was private with a driver, I did not mind.
But if made public in include/linux/netdevice.h, I would rather not
have to explain
to future users why it can be problematic.
Powered by blists - more mailing lists