linux-kernel - Re: [RFC PATCH v2 net-next 03/15] phy: ethernet: add configuration interface for copper backplane Ethernet PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231002131110.4kjkinc2xyxtdwbv@skbuf>
Date:   Mon, 2 Oct 2023 16:11:10 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Simon Horman <horms@...nel.org>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Madalin Bucur <madalin.bucur@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Camelia Groza <camelia.groza@....com>,
        Li Yang <leoyang.li@....com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor@...nel.org>,
        Sean Anderson <sean.anderson@...o.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>
Subject: Re: [RFC PATCH v2 net-next 03/15] phy: ethernet: add configuration
 interface for copper backplane Ethernet PHYs

Hi Simon,

On Thu, Sep 28, 2023 at 09:05:36PM +0200, Simon Horman wrote:
> On Sat, Sep 23, 2023 at 04:48:52PM +0300, Vladimir Oltean wrote:
> 
> ...
> 
> > +/**
> > + * coef_update_opposite - return the opposite of one C72 coefficient update
> > + *			  request
> > + *
> > + * @update:	original coefficient update
> > + *
> > + * Helper to transform the update request of one equalization tap into a
> > + * request of the same tap in the opposite direction. May be used by C72
> > + * phy remote TX link training algorithms.
> > + */
> > +static inline enum coef_update coef_update_opposite(enum coef_update update)
> 
> Hi Vladimir,
> 
> another nit from me.
> 
> Please put the inline keyword first.
> Likewise elsewhere in this patch.
> 
> Tooling, including gcc-13 with W=1, complains about this.

Thanks for pointing this out. I guess you are talking about the c72_coef_update_print()
function, whose prototype is mistakenly "static void inline" instead of
"static inline void". I cannot find the problem with the quoted coef_update_opposite().