linux-kernel - Re: [PATCH v2] mtd: rawnand: Ensure the nand chip supports cached reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231002154943.361e31b0@xps-13>
Date:   Mon, 2 Oct 2023 15:49:43 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Martin Hundebøll <martin@...nix.com>
Cc:     Rouven Czerwinski <r.czerwinski@...gutronix.de>,
        Måns Rullgård <mans@...sr.com>,
        Alexander Shiyan <eagle.alexander923@...il.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        JaimeLiao <jaimeliao.tw@...il.com>, kernel@...gutronix.de,
        stable@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Sean Nyekjær <sean@...nix.com>,
        Domenico Punzo <dpunzo@...ron.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH v2] mtd: rawnand: Ensure the nand chip supports cached
 reads

Hi Martin,

martin@...nix.com wrote on Thu, 28 Sep 2023 09:19:56 +0200:

> Hi Miquel,
> 
> On Wed, 2023-09-27 at 17:05 +0200, Miquel Raynal wrote:
> > Hi Martin,
> > 
> > miquel.raynal@...tlin.com wrote on Tue, 26 Sep 2023 13:27:25 +0200:
> >   
> > > Hi Martin,
> > > 
> > > + Bean and Domenico, there is a question for you below.
> > > 
> > > martin@...nix.com wrote on Mon, 25 Sep 2023 13:01:06 +0200:
> > >   
> > > > Hi Rouven,
> > > > 
> > > > On Fri, 2023-09-22 at 16:17 +0200, Rouven Czerwinski wrote:    
> > > > > Both the JEDEC and ONFI specification say that read cache
> > > > > sequential
> > > > > support is an optional command. This means that we not only
> > > > > need to
> > > > > check whether the individual controller supports the command,
> > > > > we also
> > > > > need to check the parameter pages for both ONFI and JEDEC NAND
> > > > > flashes
> > > > > before enabling sequential cache reads.
> > > > > 
> > > > > This fixes support for NAND flashes which don't support
> > > > > enabling
> > > > > cache
> > > > > reads, i.e. Samsung K9F4G08U0F or Toshiba TC58NVG0S3HTA00.
> > > > > 
> > > > > Sequential cache reads are now only available for ONFI and
> > > > > JEDEC
> > > > > devices, if individual vendors implement this, it needs to be
> > > > > enabled
> > > > > per vendor.
> > > > > 
> > > > > Tested on i.MX6Q with a Samsung NAND flash chip that doesn't
> > > > > support
> > > > > sequential reads.
> > > > > 
> > > > > Fixes: 003fe4b9545b ("mtd: rawnand: Support for sequential
> > > > > cache
> > > > > reads")
> > > > > Cc: stable@...r.kernel.org
> > > > > Signed-off-by: Rouven Czerwinski
> > > > > <r.czerwinski@...gutronix.de>      
> > > > 
> > > > Thanks for this. It works as expected for my Toshiba chip,
> > > > obviously
> > > > because it doesn't use ONFI or JEDEC.
> > > > 
> > > > Unfortunately, my Micron chip does use ONFI, and it sets the
> > > > cached-
> > > > read-supported bit. It then fails when reading afterwords:  
> > 
> > I might have over reacted regarding my findings in Micron's
> > datasheet,
> > I need to know if you use the on-die ECC engine or if you use the one
> > on the controller. In the former case the failure is expected. In the
> > latter case, it's not.  
> 
> I use the default, which seems to be the controller engine?

Yeah, you're using the gpmi NAND controller right? If that's the case,
it seems that only ECC correction is supported.

Thanks,
Miquèl