linux-kernel - Re: [PATCH 2/3] platform/x86: ISST : Check major minor version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4098d4a2-f672-3c72-5ddd-b397e2ed1465@linux.intel.com>
Date:   Mon, 2 Oct 2023 17:24:11 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
cc:     Hans de Goede <hdegoede@...hat.com>, markgross@...nel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] platform/x86: ISST : Check major minor version

On Mon, 2 Oct 2023, srinivas pandruvada wrote:

> On Mon, 2023-10-02 at 16:49 +0300, Ilpo Järvinen wrote:
> > On Sat, 30 Sep 2023, srinivas pandruvada wrote:
> > 
> > > On Fri, 2023-09-29 at 17:28 +0300, Ilpo Järvinen wrote:
> > > > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:
> > > > 
> > > > > Parse major and minor version number from the version field. If
> > > > > there
> > > > > is a mismatch for major version, exit from further processing
> > > > > for
> > > > > that
> > > > > domain.
> > > > > 
> > > > > If there is mismatch in minor version, driver continue to
> > > > > process
> > > > > with
> > > > > an error message.
> > > > 
> > > > This sentence sounds odd.
> > > What is the suggestion here?
> > 
> > These things sound wrong: It should be "continues"
> OK
> 
> >  but I also find "to 
> > process" odd when lacking what it processes.
> 
> Further processing means, whatever this driver is supposed to do. You
> don't want to fully explain again what this driver is doing.

Well, whatever. I'm not a native anyway so I cannot really be the defining 
authority how the language gets used so feel free to leave "to process" 
as is.

-- 
 i.