[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231002145832.GC4414@cmpxchg.org>
Date: Mon, 2 Oct 2023 10:58:32 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: "Huang, Ying" <ying.huang@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Vlastimil Babka <vbabka@...e.cz>,
Mel Gorman <mgorman@...hsingularity.net>,
Miaohe Lin <linmiaohe@...wei.com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Zi Yan <ziy@...dia.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching
On Sat, Sep 30, 2023 at 12:26:01PM +0800, Huang, Ying wrote:
> I have done more test for the series and addon patches. The test
> results are as follows,
>
> base
> perf-profile.children.get_pfnblock_flags_mask 0.15 (+- 32.62%)
> will-it-scale.1.processes 618621.7 (+- 0.18%)
>
> mm: page_alloc: remove pcppage migratetype caching
> perf-profile.children.get_pfnblock_flags_mask 0.40 (+- 21.55%)
> will-it-scale.1.processes 616350.3 (+- 0.27%)
>
> mm: page_alloc: fix up block types when merging compatible blocks
> perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 8.36%)
> will-it-scale.1.processes 617121.0 (+- 0.17%)
>
> mm: page_alloc: move free pages when converting block during isolation
> perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 15.10%)
> will-it-scale.1.processes 615578.0 (+- 0.18%)
>
> mm: page_alloc: fix move_freepages_block() range error
> perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 12.78%)
> will-it-scale.1.processes 615364.7 (+- 0.27%)
>
> mm: page_alloc: fix freelist movement during block conversion
> perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 10.52%)
> will-it-scale.1.processes 617834.8 (+- 0.52%)
>
> mm: page_alloc: consolidate free page accounting
> perf-profile.children.get_pfnblock_flags_mask 0.39 (+- 8.27%)
> will-it-scale.1.processes 621000.0 (+- 0.13%)
>
> mm: page_alloc: close migratetype race between freeing and stealing
> perf-profile.children.get_pfnblock_flags_mask 0.37 (+- 5.87%)
> will-it-scale.1.processes 618378.8 (+- 0.17%)
>
> mm: page_alloc: optimize free_unref_page_list()
> perf-profile.children.get_pfnblock_flags_mask 0.20 (+- 14.96%)
> will-it-scale.1.processes 618136.3 (+- 0.16%)
>
> It seems that the will-it-scale score is influenced by some other
> factors too. But anyway, the series + addon patches restores the score
> of will-it-scale. And the cycles% of get_pfnblock_flags_mask() is
> almost restored by the final patch (mm: page_alloc: optimize
> free_unref_page_list()).
>
> Feel free to add my "Tested-by" for these patches.
Thanks, I'll add those!
Powered by blists - more mailing lists