[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0f3ac22f-59c9-6e04-c824-dd486c20bf37@arm.com>
Date: Mon, 2 Oct 2023 16:03:40 +0100
From: James Clark <james.clark@....com>
To: Linu Cherian <lcherian@...vell.com>
Cc: linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
linux-kernel@...r.kernel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
devicetree@...r.kernel.org, sgoutham@...vell.com,
gcherian@...vell.com, Anil Kumar Reddy <areddy3@...vell.com>,
suzuki.poulose@....com, mike.leach@...aro.org, leo.yan@...aro.org
Subject: Re: [PATCH 2/7] coresight: tmc-etr: Add support to use reserved trace
memory
On 29/09/2023 14:37, Linu Cherian wrote:
> Add support to use reserved memory for coresight ETR trace buffer.
>
> Introduce a new ETR buffer mode called ETR_MODE_RESRV, which
> becomes available when ETR device tree node is supplied with a valid
> reserved memory region.
>
> ETR_MODE_RESRV can be selected only by explicit user request.
>
> $ echo resrv >/sys/bus/coresight/devices/tmc_etr<N>/buf_mode_preferred
>
> Signed-off-by: Anil Kumar Reddy <areddy3@...vell.com>
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
> ---
> .../hwtracing/coresight/coresight-tmc-core.c | 51 +++++++++++
> .../hwtracing/coresight/coresight-tmc-etr.c | 87 ++++++++++++++++++-
> drivers/hwtracing/coresight/coresight-tmc.h | 24 +++++
> 3 files changed, 161 insertions(+), 1 deletion(-)
[...]
>
> +static void tmc_get_reserved_region(struct device *parent)
> +{
> + struct tmc_drvdata *drvdata = dev_get_drvdata(parent);
> + struct device_node *node;
> + struct resource res;
> + int rc;
> +
> + node = tmc_get_region_byname(parent->of_node, "tracedata-mem");
Is this a typo? The DT commit says the region is called "trace-mem". And
"metadata-mem" for the other region, but that one matches the other call
to tmc_get_region_byname() added in the later commit.
> + if (IS_ERR_OR_NULL(node)) {
> + dev_dbg(parent, "No reserved trace buffer specified\n");
> + goto out;
> + }
> +
Powered by blists - more mailing lists