linux-kernel - Re: [RFC PATCH v5 01/11] ASoC: fsl_asrc: define functions for memory to memory usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7af54654-d4d5-498e-bd53-78ad54e6d818@sirena.org.uk>
Date:   Mon, 2 Oct 2023 16:07:57 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Shengjiu Wang <shengjiu.wang@....com>
Cc:     hverkuil@...all.nl, sakari.ailus@....fi, tfiga@...omium.org,
        m.szyprowski@...sung.com, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        shengjiu.wang@...il.com, Xiubo.Lee@...il.com, festevam@...il.com,
        nicoleotsuka@...il.com, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RFC PATCH v5 01/11] ASoC: fsl_asrc: define functions for memory
 to memory usage

On Thu, Sep 28, 2023 at 05:00:09PM +0800, Shengjiu Wang wrote:

> m2m_start_part_one: first part of the start steps
> m2m_start_part_two: second part of the start steps
> m2m_stop_part_one: first part of stop steps
> m2m_stop_part_two: second part of stop steps, optional

The part_one/two naming isn't amazing here.  Looking at the rest of the
code it looks like this is a prepare/trigger type distinction where the
first part is configuring things prior to DMA setup and the second part
is actually starting the transfer.  Perhaps _config()/_start() instead?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)