linux-kernel - [PATCH v1] iio: adc: MCP3564: fix warn: unsigned '_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231002161618.36373-1-marius.cristea@microchip.com>
Date:   Mon, 2 Oct 2023 19:16:18 +0300
From:   <marius.cristea@...rochip.com>
To:     <jic23@...nel.org>, <lars@...afoo.de>, <lgirdwood@...il.com>,
        <broonie@...nel.org>
CC:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <marius.cristea@...rochip.com>
Subject: [PATCH v1] iio: adc: MCP3564: fix warn: unsigned '__x' is never less than zero.

From: Marius Cristea <marius.cristea@...rochip.com>

The patch efea15e3c65d: "iio: adc: MCP3564: fix the static checker warning"
leads to the following Smatch static checker warning:

   smatch warnings:
   drivers/iio/adc/mcp3564.c:1105 mcp3564_fill_scale_tbls() warn: unsigned '__x' is never less than zero.

vim +/__x +1105 drivers/iio/adc/mcp3564.c

   1094
   1095  static void mcp3564_fill_scale_tbls(struct mcp3564_state *adc)
   1096  {
   .....
   1103          for (i = 0; i < MCP3564_MAX_PGA; i++) {
   1104                  ref = adc->vref_mv;
 > 1105                  tmp1 = shift_right((u64)ref * NANO, pow);
   1106                  div_u64_rem(tmp1, NANO, &tmp0);
   1107
   .....
   1113  }

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309280738.NWjVfVt4-lkp@intel.com/
Fixes: efea15e3c65d (iio: adc: MCP3564: fix the static checker warning)
Signed-off-by: Marius Cristea <marius.cristea@...rochip.com>
---
 drivers/iio/adc/mcp3564.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
index 9ede1a5d5d7b..e3f1de5fcc5a 100644
--- a/drivers/iio/adc/mcp3564.c
+++ b/drivers/iio/adc/mcp3564.c
@@ -1102,7 +1102,7 @@ static void mcp3564_fill_scale_tbls(struct mcp3564_state *adc)
 
 	for (i = 0; i < MCP3564_MAX_PGA; i++) {
 		ref = adc->vref_mv;
-		tmp1 = shift_right((u64)ref * NANO, pow);
+		tmp1 = ((u64)ref * NANO) >> pow;
 		div_u64_rem(tmp1, NANO, &tmp0);
 
 		tmp1 = tmp1 * mcp3564_hwgain_frac[(2 * i) + 1];

base-commit: 5e99f692d4e32e3250ab18d511894ca797407aec
-- 
2.34.1