linux-kernel - Re: [PATCH 0/5] mfd: qcom-spmi-pmic: fix revid implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dee25d93-28a0-40ee-9ab8-f86c89428dbd@linaro.org>
Date:   Tue, 3 Oct 2023 16:57:13 +0100
From:   Caleb Connolly <caleb.connolly@...aro.org>
To:     Johan Hovold <johan+linaro@...nel.org>, Lee Jones <lee@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] mfd: qcom-spmi-pmic: fix revid implementation



On 03/10/2023 16:29, Johan Hovold wrote:
> The Qualcomm SPMI PMIC revid implementation is broken in multiple ways
> that can lead to resource leaks and crashes. This series reworks the
> implementation so that can be used safely.
> 
> Included is also a rename of the SPMI device lookup helper which can
> hopefully help prevent similar leaks from being reintroduced.
> 
> Johan

This is.. definitely a major improvement. Thanks for cleaning up my mess

fwiw
Acked-by: Caleb Connolly <caleb.connolly@...aro.org>
> 
> 
> Johan Hovold (5):
>   mfd: qcom-spmi-pmic: fix reference leaks in revid helper
>   mfd: qcom-spmi-pmic: fix revid implementation
>   mfd: qcom-spmi-pmic: switch to EXPORT_SYMBOL_GPL()
>   spmi: document spmi_device_from_of() refcounting
>   spmi: rename spmi device lookup helper
> 
>  drivers/mfd/qcom-spmi-pmic.c | 103 +++++++++++++++++++++++++----------
>  drivers/spmi/spmi.c          |   9 ++-
>  include/linux/spmi.h         |   2 +-
>  3 files changed, 80 insertions(+), 34 deletions(-)
> 

-- 
// Caleb (they/them)