linux-kernel - Re: [PATCH] extract and use FILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73bedf42-decf-450a-8e54-a318950ddc67@p183>
Date:   Tue, 3 Oct 2023 19:20:53 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     akpm@...ux-foundation.org, Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH] extract and use FILE_LINE macro

On Mon, Oct 02, 2023 at 10:33:49AM -0700, Kees Cook wrote:
> > +#define FILE_LINE	__FILE__ ":" __stringify(__LINE__)
> > +
> >  #endif	/* !__LINUX_STRINGIFY_H */

> > --- a/sound/pci/asihpi/hpidebug.h
> > +++ b/sound/pci/asihpi/hpidebug.h
> > @@ -29,16 +29,15 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0,	/* always log errors */
> >     the start of each message, eg see linux kernel hpios.h */
> >  
> >  #ifdef SOURCEFILE_NAME
> > +#undef FILE_LINE
> >  #define FILE_LINE  SOURCEFILE_NAME ":" __stringify(__LINE__) " "
> 
> Should this drop the trailing " " to match the new macro?

Yes, probably. This SOURCEFILE_NAME is some out of tree stuff.