linux-kernel - Re: [PATCH] /bin/dmesg to dmesg Path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Oct 2023 21:16:08 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     April John <april@...b.dev>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH] /bin/dmesg to dmesg Path

Hello,

On Sun, Oct 1, 2023 at 6:10 AM April John <april@...b.dev> wrote:
>
> Dmesg is not in every distro at /bin/dmesg, in NixOS for example, this fails,
> but the path should in most cases contain dmesg.
> This follows the example of replacing /bin/bash with bash Path in the codebase.
>
> ---
> tools/perf/util/evsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a8a5ff87c..aa602aae6 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -3053,7 +3053,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
>
> return scnprintf(msg, size,
> "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
> - "/bin/dmesg | grep -i perf may provide additional information.\n",
> + "dmesg | grep -i perf may provide additional information.\n",
> err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
> }
>
> --
> 2.42.0
>
> Signed-off-by: April John <april@...b.dev>

It is usual to put a tag after the patch, it should be at the end of the
commit message.  With that,

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung