linux-kernel - Re: [PATCH v6] perf: arm_cspmu: Separate Arm and vendor module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df7ba4b1-791c-fd46-18d4-db35f2472fc1@arm.com>
Date:   Tue, 3 Oct 2023 17:39:53 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Besar Wicaksono <bwicaksono@...dia.com>,
        Ilkka Koskinen <ilkka@...amperecomputing.com>,
        "robin.murphy@....com" <robin.murphy@....com>
Cc:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Vikram Sethi <vsethi@...dia.com>,
        Richard Wiley <rwiley@...dia.com>,
        Eric Funsten <efunsten@...dia.com>
Subject: Re: [PATCH v6] perf: arm_cspmu: Separate Arm and vendor module

Hi Besar

On 03/10/2023 15:20, Besar Wicaksono wrote:
> Thanks Ilkka.
> Suzuki/Robin, can we have someone from Arm to review this patch ? It's been a while.
> 

Apologies for the delay.

> Regards,
> Besar
> 
>> -----Original Message-----
>> From: Ilkka Koskinen <ilkka@...amperecomputing.com>
>> Sent: Thursday, September 14, 2023 1:19 PM
>> To: Besar Wicaksono <bwicaksono@...dia.com>
>> Cc: suzuki.poulose@....com; robin.murphy@....com;
>> ilkka@...amperecomputing.com; catalin.marinas@....com; will@...nel.org;
>> mark.rutland@....com; linux-arm-kernel@...ts.infradead.org; linux-
>> kernel@...r.kernel.org; linux-tegra@...r.kernel.org; Thierry Reding
>> <treding@...dia.com>; Jonathan Hunter <jonathanh@...dia.com>; Vikram
>> Sethi <vsethi@...dia.com>; Richard Wiley <rwiley@...dia.com>; Eric Funsten
>> <efunsten@...dia.com>
>> Subject: Re: [PATCH v6] perf: arm_cspmu: Separate Arm and vendor module
>>
>> External email: Use caution opening links or attachments
>>
>>
>> Hi Besar,
>>
>> On Mon, 21 Aug 2023, Besar Wicaksono wrote:
>>> Arm Coresight PMU driver consists of main standard code and
>>> vendor backend code. Both are currently built as a single module.
>>> This patch adds vendor registration API to separate the two to
>>> keep things modular. The main driver requests each known backend
>>> module during initialization and defer device binding process.
>>> The backend module then registers an init callback to the main
>>> driver and continue the device driver binding process.
>>>
>>> Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>
>>
>> I tested the patch with AmpereOne patchset on top of it and it seemed to
>> work fine. In addition, the patch looks good to me.
>>
>> Reviewed-and-tested-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
>>
>>
>> Cheers, Ilkka
>>
>>> ---
>>>
>>> Changes from v5:
>>> * Incorporate review comments.
>>> * Fix arm_cspmu_impl_match_get not returning NULL if no matching impl.
>>> * Fix impl_match.module may reset when registering PMU.
>>> * Maintain backend module ref count until PMU registration is done.
>>> Thanks to Will, Suzuki, and Robin for the feedback.
>>> v5: https://lore.kernel.org/linux-arm-kernel/20230705104745.52255-1-
>> bwicaksono@...dia.com/T/#u

The changes to address the comments from v5, looks good to me. Thanks
for fixing them.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>