lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <202310031907.45632.linux@zary.sk>
Date:   Tue, 3 Oct 2023 19:07:45 +0200
From:   Ondrej Zary <linux@...y.sk>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Christoph Hellwig <hch@....de>, Tim Waugh <tim@...erelk.net>,
        linux-parport@...ts.infradead.org, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] pata_parport: fix pata_parport_devchk

On Monday 02 October 2023 20:43:09 Sergey Shtylyov wrote:
> Hello!
> 
> On 9/30/23 10:15 PM, Ondrej Zary wrote:
> 
> > There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the
> > detection to always fail. Fix it.
> > 
> > Signed-off-by: Ondrej Zary <linux@...y.sk>
> 
>    I think we need a Fixes: tag here...
> 
> > ---
> >  drivers/ata/pata_parport/pata_parport.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
> > index 1af64d435d3c..258d189f42e5 100644
> > --- a/drivers/ata/pata_parport/pata_parport.c
> > +++ b/drivers/ata/pata_parport/pata_parport.c
> > @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
> >  	pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa);
> >  	pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55);
> >  
> > -	pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055);
> > +	pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55);
> 
>    Oh, Gawd! How did this ever work?! :-/
>    This bug seems to predate the Big PARIDE move...

This code was not present in PARIDE - it's my bug.
The function is a clone of ata_devchk() without direct port access.
It's called only from softreset so nobody notices the breakage until something goes wrong. The CD-865 drive needs a reset to start working.

-- 
Ondrej Zary

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ