linux-kernel - Re: [PATCH v3 5/9] maple_tree: Update the documentation of maple tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231003184625.lqnfmgc35o7pgeff@revolver>
Date:   Tue, 3 Oct 2023 14:46:25 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Peng Zhang <zhangpeng.00@...edance.com>
Cc:     corbet@....net, akpm@...ux-foundation.org, willy@...radead.org,
        brauner@...nel.org, surenb@...gle.com, michael.christie@...cle.com,
        mjguzik@...il.com, mathieu.desnoyers@...icios.com,
        npiggin@...il.com, peterz@...radead.org, oliver.sang@...el.com,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3 5/9] maple_tree: Update the documentation of maple tree

* Peng Zhang <zhangpeng.00@...edance.com> [230924 23:58]:
> Introduce the new interface mtree_dup() in the documentation.
> 
> Signed-off-by: Peng Zhang <zhangpeng.00@...edance.com>
> ---
>  Documentation/core-api/maple_tree.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/core-api/maple_tree.rst b/Documentation/core-api/maple_tree.rst
> index 45defcf15da7..3d8a1edf6d04 100644
> --- a/Documentation/core-api/maple_tree.rst
> +++ b/Documentation/core-api/maple_tree.rst
> @@ -81,6 +81,9 @@ section.
>  Sometimes it is necessary to ensure the next call to store to a maple tree does
>  not allocate memory, please see :ref:`maple-tree-advanced-api` for this use case.
>  
> +You can use mtree_dup() to duplicate an identical tree. It is a more efficient

"You can use mtree_dup() to create an identical tree."  duplicate an
identical tree seems redundant.

> +way than inserting all elements one by one into a new tree.
> +
>  Finally, you can remove all entries from a maple tree by calling
>  mtree_destroy().  If the maple tree entries are pointers, you may wish to free
>  the entries first.
> @@ -112,6 +115,7 @@ Takes ma_lock internally:
>   * mtree_insert()
>   * mtree_insert_range()
>   * mtree_erase()
> + * mtree_dup()
>   * mtree_destroy()
>   * mt_set_in_rcu()
>   * mt_clear_in_rcu()
> -- 
> 2.20.1
>