[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdZsQN5V0Nt46dQmUiQo-co81Z_TrzWW_9CPJEbF+X-vnw@mail.gmail.com>
Date: Tue, 3 Oct 2023 22:49:10 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc: sudeep.holla@....com, cristian.marussi@....com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
Oleksii_Moisieiev@...m.com, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org
Subject: Re: [RFC 1/4] pinctrl: define PIN_CONFIG_INPUT
Hi Takahiro,
On Mon, Oct 2, 2023 at 4:17 AM AKASHI Takahiro
<takahiro.akashi@...aro.org> wrote:
> This allows for enabling SCMI pinctrl based GPIO driver to obtain
> an input gpio pin.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
(...)
> + * @PIN_CONFIG_INPUT: This will obtain a value on an input pin. The returned
> + * argument indicates the value.
We need to specify that this is the inverse of @PIN_CONFIG_OUTPUT,
that setting a line into *input mode* requires the use of
@PIN_CONFIG_INPUT_ENABLE, so the config can never be set
but should return an error on set, and that the argument returned is 1 for
logic high and 0 for logic low.
Otherwise I think this is fine!
Yours,
Linus Walleij
Powered by blists - more mailing lists