| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <169631484962.3548819.1223779643388796546.robh@kernel.org>
Date: Tue, 03 Oct 2023 01:34:09 -0500
From: Rob Herring <robh@...nel.org>
To: Rafał Miłecki <zajec5@...il.com>
Cc: Pengutronix Kernel Team <kernel@...gutronix.de>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Christian Marangi <ansuelsmth@...il.com>,
Hector Martin <marcan@...can.st>,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
Neil Armstrong <neil.armstrong@...aro.org>,
NXP Linux Team <linux-imx@....com>,
Komal Bajaj <quic_kbajaj@...cinc.com>,
linux-rtc@...r.kernel.org,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-mtd@...ts.infradead.org,
Jerome Brunet <jbrunet@...libre.com>,
Vincent Shih <vincent.sunplus@...il.com>,
asahi@...ts.linux.dev, Rob Herring <robh+dt@...nel.org>,
Anson Huang <Anson.Huang@....com>,
Andy Gross <agross@...nel.org>,
linux-rockchip@...ts.infradead.org,
Vignesh Raghavendra <vigneshr@...com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Richard Weinberger <richard@....at>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Heiko Stuebner <heiko@...ech.de>,
Fabio Estevam <festevam@...il.com>,
Conor Dooley <conor+dt@...nel.org>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Bjorn Andersson <andersson@...nel.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Sven Peter <sven@...npeter.dev>,
linux-arm-kernel@...ts.infradead.org,
Miquel Raynal <miquel.raynal@...tlin.com>,
Shawn Guo <shawnguo@...nel.org>,
Kumar Thella <sthella@...eaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
devicetree@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
linux-arm-msm@...r.kernel.org,
Keiji Hayashibara <hayashibara.keiji@...ionext.com>,
Kevin Hilman <khilman@...libre.com>,
Rafał Miłecki <rafal@...ecki.pl>,
linux-mediatek@...ts.infradead.org,
Lala Lin <lala.lin@...iatek.com>
Subject: Re: [PATCH] dt-bindings: nvmem: move deprecated cells binding to
its own file
On Tue, 03 Oct 2023 07:03:55 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> Support for old NVMEM fixed cells was deprecated in favour of
> "fixed-layout". It's still part of the nvmem.yaml though and may be
> unknowingly used by new bindings added without much of analyze.
>
> To make it more difficult to accidentally support old syntax move its
> binding to separated file with "deprecated" in its name.
>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---
> .../devicetree/bindings/mtd/mtd.yaml | 7 ++++-
> .../bindings/mtd/partitions/nvmem-cells.yaml | 1 +
> .../nvmem/amlogic,meson-gxbb-efuse.yaml | 1 +
> .../bindings/nvmem/amlogic,meson6-efuse.yaml | 1 +
> .../bindings/nvmem/apple,efuses.yaml | 1 +
> .../devicetree/bindings/nvmem/imx-ocotp.yaml | 1 +
> .../bindings/nvmem/mediatek,efuse.yaml | 1 +
> .../nvmem/microchip,sama7g5-otpc.yaml | 1 +
> .../devicetree/bindings/nvmem/mxs-ocotp.yaml | 1 +
> .../nvmem/nvmem-deprecated-cells.yaml | 28 +++++++++++++++++++
> .../devicetree/bindings/nvmem/nvmem.yaml | 9 ------
> .../bindings/nvmem/qcom,qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,sec-qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,spmi-sdam.yaml | 1 +
> .../bindings/nvmem/rockchip,otp.yaml | 1 +
> .../bindings/nvmem/rockchip-efuse.yaml | 1 +
> .../nvmem/socionext,uniphier-efuse.yaml | 1 +
> .../bindings/nvmem/sunplus,sp7021-ocotp.yaml | 1 +
> .../bindings/rtc/amlogic,meson6-rtc.yaml | 1 +
> 19 files changed, 50 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/rtc/nvmem-deprecated-cells.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: False schema does not allow {'compatible': ['amlogic,meson6-rtc'], 'reg': [[1856, 20]], 'interrupts': [[0, 72, 1]], 'clocks': [[4294967295]], 'vdd-supply': [[4294967295]], 'resets': [[4294967295]], '#address-cells': [[1]], '#size-cells': [[1]], 'mac@0': {'reg': [[0, 6]]}, '$nodename': ['rtc@...']}
from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: Unevaluated properties are not allowed ('mac@0' was unexpected)
from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003050355.1631-1-zajec5@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists