linux-kernel - Re: [PATCH v6 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8749e98-7ead-939e-6fa6-35779593a5f4@ti.com>
Date:   Tue, 3 Oct 2023 12:18:26 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Keerthy <j-keerthy@...com>, <robh+dt@...nel.org>, <nm@...com>,
        <conor+dt@...nel.org>, <kristo@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>
CC:     <u-kumar1@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 4/7] arm64: dts: ti: k3-j784s4-main: Add the main
 domain watchdog instances



On 27/09/23 08:03, Keerthy wrote:
> +	/*
> +	 * The following RTI instances are coupled with MCU R5Fs, c7x and
> +	 * GPU so keeping them disabled as these will be used by their
> +	 * respective firmware
> +	 */
> +	watchdog16: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2300000 0x00 0x100>;
> +		clocks = <&k3_clks 356 1>;
> +		power-domains = <&k3_pds 356 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 356 0>;
> +		assigned-clock-parents = <&k3_clks 356 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog17: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2310000 0x00 0x100>;
> +		clocks = <&k3_clks 357 1>;
> +		power-domains = <&k3_pds 357 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 357 0>;
> +		assigned-clock-parents = <&k3_clks 357 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog18: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2320000 0x00 0x100>;
> +		clocks = <&k3_clks 358 1>;
> +		power-domains = <&k3_pds 358 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 358 0>;
> +		assigned-clock-parents = <&k3_clks 358 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog19: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2330000 0x00 0x100>;
> +		clocks = <&k3_clks 359 1>;
> +		power-domains = <&k3_pds 359 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 359 0>;
> +		assigned-clock-parents = <&k3_clks 359 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog15: watchdog@...0000 {


I understand you are arranging based on Firmware Device ID. But these
numbers don't have much meaning when user maps to TRM. So, I suggest
nodes to be arranged by TRM numbering or ascending order of register
address so that its easier for end user to map the nodes to IP  instance
in TRM.

> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x22f0000 0x00 0x100>;
> +		clocks = <&k3_clks 360 1>;
> +		power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 360 0>;
> +		assigned-clock-parents = <&k3_clks 360 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog28: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x23c0000 0x00 0x100>;
> +		clocks = <&k3_clks 361 1>;
> +		power-domains = <&k3_pds 361 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 361 0>;
> +		assigned-clock-parents = <&k3_clks 361 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog29: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x23d0000 0x00 0x100>;
> +		clocks = <&k3_clks 362 1>;
> +		power-domains = <&k3_pds 362 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 362 0>;
> +		assigned-clock-parents = <&k3_clks 362 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog30: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x23e0000 0x00 0x100>;
> +		clocks = <&k3_clks 363 1>;
> +		power-domains = <&k3_pds 363 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 363 0>;
> +		assigned-clock-parents = <&k3_clks 363 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog31: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x23f0000 0x00 0x100>;
> +		clocks = <&k3_clks 364 1>;
> +		power-domains = <&k3_pds 364 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 364 0>;
> +		assigned-clock-parents = <&k3_clks 364 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog32: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2540000 0x00 0x100>;
> +		clocks = <&k3_clks 365 1>;
> +		power-domains = <&k3_pds 365 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 365 0>;
> +		assigned-clock-parents = <&k3_clks 366 4>;
> +		status = "disabled";
> +	};
> +
> +	watchdog33: watchdog@...0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x2550000 0x00 0x100>;
> +		clocks = <&k3_clks 366 1>;
> +		power-domains = <&k3_pds 366 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 366 0>;
> +		assigned-clock-parents = <&k3_clks 366 4>;
> +		status = "disabled";
> +	};
>  };
> -- 2.17.1

-- 
Regards
Vignesh