linux-kernel - Re: [PATCH] drivers/clocksource/timer-ti-dm: Don't call clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231003075708.GA34982@atomide.com>
Date:   Tue, 3 Oct 2023 10:57:08 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc:     daniel.lezcano@...aro.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, sean@...s.org
Subject: Re: [PATCH] drivers/clocksource/timer-ti-dm: Don't call
 clk_get_rate() in stop function

* Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com> [231003 05:50]:
> clk_get_rate() might sleep, and that prevents dm-timer based PWM from being
> used from atomic context.
> 
> Fix that by getting fclk rate in probe() and using a notifier in case rate
> changes.

Makes sense to me:

Reviewed-by: Tony Lindgren <tony@...mide.com>