linux-kernel - Re: [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tstb2fxrio26yhu4cbeblq6rpo7hsqfa3ydrz54lmk2gbbegnl@qsvfevchllkd>
Date:   Tue, 3 Oct 2023 13:32:26 +0530
From:   Jai Luthra <j-luthra@...com>
To:     Aradhya Bhatia <a-bhatia1@...com>
CC:     Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devarsht@...com>
Subject: Re: [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz

Hi Aradhya,

On Oct 03, 2023 at 10:54:12 +0530, Aradhya Bhatia wrote:
> 
> 
> On 28-Sep-23 14:54, Jai Luthra wrote:
> > The TLV320AIC3106 audio codec is interfaced on the i2c-1 bus. With the
> > default rate of 400Khz the i2c register writes fail to sync:
> > 
> > [   36.026387] tlv320aic3x 1-001b: Unable to sync registers 0x16-0x16. -110
> > [   38.101130] omap_i2c 20010000.i2c: controller timed out
> > 
> > Dropping the rate to 100Khz fixes the issue.
> > 
> > Reviewed-by: Devarsh Thakkar <devarsht@...com>
> > Signed-off-by: Jai Luthra <j-luthra@...com>
> 
> Since the codec wouldn't have worked with the 400KHz, the initial DT
> configuration is wrong, which makes this patch a fix, and should be
> indicated as such.

I am slightly confused, as the codec node was not enumerated before this 
series, and i2c-1 configuration @ 400Khz works for the GPIO expanders 
present.

My understanding is that a Fixes: tag would mean we backport this patch 
to older releases, but that would not really be necessary here as 
nothing was per se "broken" before this series.

Will discuss this offline with you and Vignesh and send a v3.

> 
> With the Fixes tag added,
> 
> Reviewed-by: Aradhya Bhatia <a-bhatia1@...com>
> 
> Regards
> Aradhya
> 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> > index c689d3da2def..866b2725f775 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> > @@ -261,7 +261,7 @@ &main_i2c1 {
> >  	status = "okay";
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&main_i2c1_pins_default>;
> > -	clock-frequency = <400000>;
> > +	clock-frequency = <100000>;
> >  
> >  	exp1: gpio@22 {
> >  		compatible = "ti,tca6424";
> > 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)