linux-kernel - Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c00918f-4bc1-4096-8e79-2a08d835210b@kernel.org>
Date:   Tue, 3 Oct 2023 11:49:22 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Crescent CY Hsieh <crescentcy.hsieh@...a.com>
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in
 8250_pci.c

On 03. 10. 23, 9:30, Greg KH wrote:
>> Should I put these macros into pci_ids.h? If so, I am willing to help
>> relocate all other macros.
> 
> Please do not add new defines to pci_ids.h unless they are needed in
> multiple files.

(Which VENDOR_MOXA is, but DEVICE ids are not.)


-- 
js
suse labs