[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZRvkM1lxsTrHb2Ox@gmail.com>
Date: Tue, 3 Oct 2023 11:51:47 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
bristot@...hat.com, vschneid@...hat.com,
linux-kernel@...r.kernel.org,
kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it
child
* Yajun Deng <yajun.deng@...ux.dev> wrote:
> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
> it should not place out of RT_GROUP_SCHED, move back to RT_GROUP_SCHED
> and rename it child.
>
> Init child when parent isn't NULL in init_tg_rt_entry().
>
> Introduce for_each_sched_rt_entity_reverse() to iterate rt_se from
> top to down.
>
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202308031034.4369b15b-oliver.sang@intel.com
Yeah, so I agree with these changes, but could you please split up this
patch into 3 separate patches:
sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
sched/rt: Rename sched_rt_entity::back to sched_rt_entity::child
sched/rt: Introduce for_each_sched_rt_entity_reverse() & use it
Thanks,
Ingo
Powered by blists - more mailing lists