lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231003101748.GA32191@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date:   Tue, 3 Oct 2023 03:17:48 -0700
From:   Shradha Gupta <shradhagupta@...ux.microsoft.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
        decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
        paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
        davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, leon@...nel.org,
        longli@...rosoft.com, ssengar@...ux.microsoft.com,
        linux-rdma@...r.kernel.org, daniel@...earbox.net,
        john.fastabend@...il.com, bpf@...r.kernel.org, ast@...nel.org,
        sharmaajay@...rosoft.com, hawk@...nel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net,v2, 2/3] net: mana: Fix the tso_bytes calculation

On Fri, Sep 29, 2023 at 01:42:26PM -0700, Haiyang Zhang wrote:
> sizeof(struct hop_jumbo_hdr) is not part of tso_bytes, so remove
> the subtraction from header size.
> 
> Cc: stable@...r.kernel.org
> Fixes: bd7fc6e1957c ("net: mana: Add new MANA VF performance counters for easier troubleshooting")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/net/ethernet/microsoft/mana/mana_en.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index 5cdcf7561b38..86e724c3eb89 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -264,8 +264,6 @@ netdev_tx_t mana_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>  				ihs = skb_transport_offset(skb) + sizeof(struct udphdr);
>  			} else {
>  				ihs = skb_tcp_all_headers(skb);
> -				if (ipv6_has_hopopt_jumbo(skb))
> -					ihs -= sizeof(struct hop_jumbo_hdr);
>  			}
>  
>  			u64_stats_update_begin(&tx_stats->syncp);
> -- 
> 2.25.1
Reviewed-by:Shradha Gupta <shradhagupta@...ux.microsoft.com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ