linux-kernel - Re: [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdjB6wqeezL_UotQj-65HKb83wYh4hfA=PPiooRN0QX8Q@mail.gmail.com>
Date:   Tue, 3 Oct 2023 13:49:40 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     ulf.hansson@...aro.org, avifishman70@...il.com,
        tali.perry1@...il.com, joel@....id.au, venture@...gle.com,
        yuenn@...gle.com, benjaminfair@...gle.com, adrian.hunter@...el.com,
        skhan@...uxfoundation.org, davidgow@...gle.com,
        pbrobinson@...il.com, gsomlo@...il.com, briannorris@...omium.org,
        arnd@...db.de, krakoczy@...micro.com, openbmc@...ts.ozlabs.org,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

On Mon, Oct 2, 2023 at 11:06 PM Tomer Maimon <tmaimon77@...il.com> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

...

> +static const struct of_device_id npcm_sdhci_of_match[] = {
> +       { .compatible = "nuvoton,npcm750-sdhci", .data = &npcm7xx_sdhci_pdata, },
> +       { .compatible = "nuvoton,npcm845-sdhci", .data = &npcm8xx_sdhci_pdata, },

Only in case when you need a new version, you may remove the inner
trailing commas,
no  need to do this right now.

> +       { }
> +};

-- 
With Best Regards,
Andy Shevchenko