linux-kernel - Re: [PATCH v9 06/14] USB: typec: tps6598x: Clear dead battery flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRv3SRwZ9hbtA3ka@primary>
Date:   Tue, 3 Oct 2023 07:13:13 -0400
From:   Abdel Alkuor <alkuor@...il.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, bryan.odonoghue@...aro.org,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, ryan.eleceng@...il.com,
        robh+dt@...nel.org, conor+dt@...nel.org,
        devicetree@...r.kernel.org, Abdel Alkuor <abdelalkuor@...tab.com>
Subject: Re: [PATCH v9 06/14] USB: typec: tps6598x: Clear dead battery flag

On Tue, Oct 03, 2023 at 09:03:42AM +0300, Heikki Krogerus wrote:
> On Sun, Oct 01, 2023 at 04:11:26AM -0400, Abdel Alkuor wrote:
> > From: Abdel Alkuor <abdelalkuor@...tab.com>
> > 
> > Dead battery flag must be cleared after switching tps25750 to APP mode
> > so the PD controller becomes fully functional.
> > 
> > Signed-off-by: Abdel Alkuor <abdelalkuor@...tab.com>
> 
> I'm sorry I noticed these so late, but this one really feels like it
> should be part of the patch 4/14. Is there some reason why you do this
> separately?
>
That's a good. There is no actual reason, it was just simply part of the
implementation flow. I will move it to be part the patch that supports
tps25750 implementation

Thanks,
Abdel
> Br,
> 
> -- 
> heikki