linux-kernel - Re: [PATCH] modpost: Optimize symbol search from linear to binary search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARbPoTVG83kuHzD1mkwWn5Rqth1iYhfXbnsrk2LOvyHYg@mail.gmail.com>
Date:   Tue, 3 Oct 2023 20:35:28 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Jack Brennen <jbrennen@...gle.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>, Tom Rix <trix@...hat.com>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        llvm@...ts.linux.dev, maskray@...gle.com, cleger@...osinc.com,
        kernel-team@...roid.com, joe@...ches.com
Subject: Re: [PATCH] modpost: Optimize symbol search from linear to binary search

On Tue, Sep 26, 2023 at 9:40 PM Jack Brennen <jbrennen@...gle.com> wrote:
>
> Modify modpost to use binary search for converting addresses back
> into symbol references.  Previously it used linear search.
>
> This change saves a few seconds of wall time for defconfig builds,
> but can save several minutes on allyesconfigs.
>
> Before:
> $ make LLVM=1 -j128 allyesconfig vmlinux -s KCFLAGS="-Wno-error"
> $ time scripts/mod/modpost -M -m -a -N -o vmlinux.symvers vmlinux.o
> 198.38user 1.27system 3:19.71elapsed
>
> After:
> $ make LLVM=1 -j128 allyesconfig vmlinux -s KCFLAGS="-Wno-error"
> $ time scripts/mod/modpost -M -m -a -N -o vmlinux.symvers vmlinux.o
> 11.91user 0.85system 0:12.78elapsed
>
> Signed-off-by: Jack Brennen <jbrennen@...gle.com>
> Tested-by: Nick Desaulniers <ndesaulniers@...gle.com>



Applied to linux-kbuild.
Thanks.



-- 
Best Regards
Masahiro Yamada