[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <169633539510.282606.1450427416869008072.robh@kernel.org>
Date: Tue, 03 Oct 2023 07:16:35 -0500
From: Rob Herring <robh@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: quic_narepall@...cinc.com, bmasney@...hat.com,
krzysztof.kozlowski+dt@...aro.org, quic_nitirawa@...cinc.com,
vireshk@...nel.org, quic_asutoshd@...cinc.com,
quic_bhaskarv@...cinc.com, avri.altman@....com,
krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com,
robh+dt@...nel.org, quic_cang@...cinc.com,
quic_nguyenb@...cinc.com, quic_ziqichen@...cinc.com,
jejb@...ux.ibm.com, cw00.choi@...sung.com, andersson@...nel.org,
bvanassche@....org, conor+dt@...nel.org, kyungmin.park@...sung.com,
martin.petersen@...cle.com, nm@...com,
linux-kernel@...r.kernel.org, quic_richardp@...cinc.com,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-scsi@...r.kernel.org, myungjoo.ham@...sung.com,
konrad.dybcio@...aro.org, linux-arm-msm@...r.kernel.org,
sboyd@...nel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: ufs: common: add OPP table
On Tue, 03 Oct 2023 16:42:27 +0530, Manivannan Sadhasivam wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Except scaling UFS and bus clocks, it's necessary to scale also the
> voltages of regulators or power domain performance state levels. Adding
> Operating Performance Points table allows to adjust power domain
> performance state, depending on the UFS clock speed.
>
> OPPv2 deprecates previous property limited to clock scaling:
> freq-table-hz.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
> .../devicetree/bindings/ufs/ufs-common.yaml | 36 ++++++++++++++++---
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:90:20: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:26: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:36: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003111232.42663-2-manivannan.sadhasivam@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists