[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c31bcd98-cc0a-4edf-945b-f4e22e122b46@astralinux.ru>
Date: Tue, 3 Oct 2023 15:20:16 +0300
From: Анастасия Любимова
<abelova@...ralinux.ru>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
Mike Looijmans <mike.looijmans@...ic.nl>,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: Re: [PATCH] clk: cdce925: change condition in cdce925_clk_round_rate
01/09/23 16:03, Anastasia Belova пишет:
Just a friendly reminder.
> To avoid division by zero add check if
> divider is zero.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 19fbbbbcd3a3 ("Add TI CDCE925 I2C controlled clock synthesizer driver")
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
> ---
> drivers/clk/clk-cdce925.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
> index 96ac90364847..d903cdc3ad7d 100644
> --- a/drivers/clk/clk-cdce925.c
> +++ b/drivers/clk/clk-cdce925.c
> @@ -441,7 +441,7 @@ static long cdce925_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> unsigned long l_parent_rate = *parent_rate;
> u16 divider = cdce925_calc_divider(rate, l_parent_rate);
>
> - if (l_parent_rate / divider != rate) {
> + if (divider && l_parent_rate / divider != rate) {
> l_parent_rate = cdce925_clk_best_parent_rate(hw, rate);
> divider = cdce925_calc_divider(rate, l_parent_rate);
> *parent_rate = l_parent_rate;
Powered by blists - more mailing lists