linux-kernel - Re: [PATCH v1 1/1] ACPI: x86: s2idle: Switch to use acpi_evaluate_dsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Oct 2023 15:51:15 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Mario Limonciello <mario.limonciello@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] ACPI: x86: s2idle: Switch to use acpi_evaluate_dsm_typed()

On Mon, Oct 2, 2023 at 4:05 PM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> On 10/2/2023 08:52, Andy Shevchenko wrote:
> > The acpi_evaluate_dsm_typed() provides a way to check the type of the
> > object evaluated by _DSM call. Use it instead of open coded variant.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>

Applied as 6.7 material, thanks!

> > ---
> >   drivers/acpi/x86/s2idle.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> > index 08f7c6708206..7d64e655f1b8 100644
> > --- a/drivers/acpi/x86/s2idle.c
> > +++ b/drivers/acpi/x86/s2idle.c
> > @@ -417,11 +417,10 @@ static int validate_dsm(acpi_handle handle, const char *uuid, int rev, guid_t *d
> >       int ret = -EINVAL;
> >
> >       guid_parse(uuid, dsm_guid);
> > -     obj = acpi_evaluate_dsm(handle, dsm_guid, rev, 0, NULL);
> >
> >       /* Check if the _DSM is present and as expected. */
> > -     if (!obj || obj->type != ACPI_TYPE_BUFFER || obj->buffer.length == 0 ||
> > -         obj->buffer.length > sizeof(u32)) {
> > +     obj = acpi_evaluate_dsm_typed(handle, dsm_guid, rev, 0, NULL, ACPI_TYPE_BUFFER);
> > +     if (!obj || obj->buffer.length == 0 || obj->buffer.length > sizeof(u32)) {
> >               acpi_handle_debug(handle,
> >                               "_DSM UUID %s rev %d function 0 evaluation failed\n", uuid, rev);
> >               goto out;
>