[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49bb695e-cb7b-41bf-a3ac-71a8a8417c9f@quicinc.com>
Date: Tue, 3 Oct 2023 19:58:02 +0530
From: Praveenkumar I <quic_ipkumar@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
<kishon@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<gregkh@...uxfoundation.org>, <catalin.marinas@....com>,
<will@...nel.org>, <p.zabel@...gutronix.de>,
<geert+renesas@...der.be>, <arnd@...db.de>,
<neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
<u-kumar1@...com>, <peng.fan@....com>, <quic_wcheng@...cinc.com>,
<quic_varada@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
CC: <quic_kathirav@...cinc.com>, <quic_nsekar@...cinc.com>,
<quic_srichara@...cinc.com>
Subject: Re: [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY
node
On 9/30/2023 10:52 PM, Dmitry Baryshkov wrote:
> On 29/09/2023 11:42, Praveenkumar I wrote:
>> Add USB Super-Speed UNIPHY node and populate the phandle on
>> gcc node for the parent clock map.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index d3fef2f80a81..b08ffd8c094e 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -158,6 +158,29 @@ usbphy0: phy@...00 {
>> status = "disabled";
>> };
>> + usbphy1: phy@...000 {
>
> Are there other USB PHYs on this platform?
No. Only two USB PHYs.
>
>> + compatible = "qcom,ipq5332-usb-uniphy";
>> + reg = <0x4b0000 0x800>;
>> +
>> + clocks = <&gcc GCC_PCIE3X1_PHY_AHB_CLK>,
>> + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>,
>> + <&gcc GCC_USB0_PIPE_CLK>;
>> + clock-names = "ahb",
>> + "cfg_ahb",
>> + "pipe";
>> +
>> + resets = <&gcc GCC_USB0_PHY_BCR>;
>> +
>> + #clock-cells = <0>;
>> + clock-output-names = "usb0_pipe_clk_src";
>
> I'm not sure, what is the best approach her. For QMP USB and PCIe PHYs
> we had to use fixed names historically. On the other hand for QMP DP
> clocks we are fine with the generated names. I'd prefer the latter case.
Sure, will use the generated names.
>
>> +
>> + qcom,phy-usb-mux-sel = <&tcsr 0x10540>;
>> +
>> + #phy-cells = <0>;
>> +
>> + status = "disabled";
>> + };
>> +
>> qfprom: efuse@...00 {
>> compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
>> reg = <0x000a4000 0x721>;
>> @@ -200,7 +223,7 @@ gcc: clock-controller@...0000 {
>> <&sleep_clk>,
>> <0>,
>> <0>,
>> - <0>;
>> + <&usbphy1>;
>> };
>> tcsr_mutex: hwlock@...5000 {
>
--
Thanks,
Praveenkumar
Powered by blists - more mailing lists