linux-kernel - Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use devm_clk_get_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZRwpvYn9xSm3+F/T@smile.fi.intel.com>
Date:   Tue, 3 Oct 2023 17:48:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use
 devm_clk_get_optional_enabled()

On Tue, Oct 03, 2023 at 05:12:41PM +0300, Andy Shevchenko wrote:

Seems the old version had been sent...

...

> +	baud_mux_clk = devm_clk_get_optional_enabled(dev, "sw_baud");

Here should be

	ret = PTR_ERR_OR_ZERO(baud_mux_clk);

> +	if (IS_ERR(baud_mux_clk))

	if (ret)

> +		goto release_dma;


...I'll send a v2 later on. Sorry for the noise.

-- 
With Best Regards,
Andy Shevchenko