[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VeuX0sG3bncz47wdXO==zO0CUhdP-b628wMw4TdZMh0Cw@mail.gmail.com>
Date: Tue, 3 Oct 2023 18:10:00 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 02/36] pinctrl: provide new GPIO-to-pinctrl glue helpers
On Tue, Oct 3, 2023 at 6:08 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Tue, Oct 3, 2023 at 5:51 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
...
> > + * pinctrl_gpio_request_new() - request a single pin to be used as GPIO
>
> "new" is too broad and too odd suffix, what I would see as a better
> alternative(s) is (are):
>
> pinctrl_gpiochip_request()
> pinctrl_gpio_chip_request()
> pinctrl_gc_request()
>
> (sorted by personal preference from high to low).
>
> The similar comment to all of them.
Or since it's about the GPIO line
pinctrl_gpio_line_request()
(and other variants near to this).
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists