[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <25ba48de-2ab6-4a4e-a290-891398710931@gmail.com>
Date: Wed, 4 Oct 2023 21:10:47 +0200
From: Maximilian Luz <luzmaximilian@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
Bjorn Andersson <andersson@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] firmware: qcom: qseecom: add missing include guards
On 10/4/23 20:57, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> The qseecom header does not contain ifdef guards against multiple
> inclusion. Add them.
>
> Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Oh, thanks for spotting and fixing that.
Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>
PS: I haven't forgotten about your SHM Bridge patches. Testing those is
now next up on my kernel TODO list. Unfortunately, it might take a
couple more days until I can get around to do it properly.
> ---
> include/linux/firmware/qcom/qcom_qseecom.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/firmware/qcom/qcom_qseecom.h b/include/linux/firmware/qcom/qcom_qseecom.h
> index b531547e1dc9..5c28298a98be 100644
> --- a/include/linux/firmware/qcom/qcom_qseecom.h
> +++ b/include/linux/firmware/qcom/qcom_qseecom.h
> @@ -5,6 +5,10 @@
> *
> * Copyright (C) 2023 Maximilian Luz <luzmaximilian@...il.com>
> */
> +
> +#ifndef __QCOM_QSEECOM_H
> +#define __QCOM_QSEECOM_H
> +
> #include <linux/auxiliary_bus.h>
> #include <linux/types.h>
>
> @@ -44,3 +48,5 @@ static inline int qcom_qseecom_app_send(struct qseecom_client *client, void *req
> {
> return qcom_scm_qseecom_app_send(client->app_id, req, req_size, rsp, rsp_size);
> }
> +
> +#endif /* __QCOM_QSEECOM_H */
Powered by blists - more mailing lists