linux-kernel - Re: [PATCH v2] memcontrol: only transfer the memcg data for migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=Pa1ADcfQJWskjwtGBVGB7BH1MCauSoZYJR54QGrfqd6A@mail.gmail.com>
Date:   Wed, 4 Oct 2023 12:53:02 -0700
From:   Nhat Pham <nphamcs@...il.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     akpm@...ux-foundation.org, riel@...riel.com, mhocko@...nel.org,
        roman.gushchin@...ux.dev, shakeelb@...gle.com,
        muchun.song@...ux.dev, tj@...nel.org, lizefan.x@...edance.com,
        shuah@...nel.org, mike.kravetz@...cle.com, yosryahmed@...gle.com,
        fvdl@...gle.com, linux-mm@...ck.org, kernel-team@...a.com,
        linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH v2] memcontrol: only transfer the memcg data for migration

On Wed, Oct 4, 2023 at 12:46 PM Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Wed, Oct 04, 2023 at 12:36:22PM -0700, Nhat Pham wrote:
> > For most migration use cases, only transfer the memcg data from the old
> > folio to the new folio, and clear the old folio's memcg data. No
> > charging and uncharging will be done.
> >
> > This shaves off some work on the migration path, and avoids the
> > temporary double charging of a folio during its migration.
> >
> > The only exception is replace_page_cache_folio(), which will use the old
> > mem_cgroup_migrate() (now renamed to mem_cgroup_replace_folio). In that
> > context, the isolation of the old page isn't quite as thorough as with
> > migration, so we cannot use our new implementation directly.
> >
> > This patch is the result of the following discussion on the new hugetlb
> > memcg accounting behavior:
> >
> > https://lore.kernel.org/lkml/20231003171329.GB314430@monkey/
> >
> > This should be added as the second prep patch in the following series:
> > https://lore.kernel.org/all/20231003001828.2554080-1-nphamcs@gmail.com/
> > (hugetlb memcg accounting)
> >
> > and should go right before the following patch:
> > hugetlb: memcg: account hugetlb-backed memory in memory controller
> >
> > Reported-by: Mike Kravetz <mike.kravetz@...cle.com>
> > Closes: https://lore.kernel.org/lkml/20231003171329.GB314430@monkey/
>
> These two tags shouldn't be here, but in the fixlet instead. This is
> the dependency patch. Otherwise looks good to me:
>
> > Suggested-by: Johannes Weiner <hannes@...xchg.org>
> > Signed-off-by: Nhat Pham <nphamcs@...il.com>
>
> Acked-by: Johannes Weiner <hannes@...xchg.org>

Thanks for the review, Johannes!