linux-kernel - Re: [PATCH] block: Fix regression in sed-opal for a saved key.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43b1a228-9a60-40ef-936b-c8a062d7eb21@kernel.dk>
Date:   Wed, 4 Oct 2023 14:28:51 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Milan Broz <gmazyland@...il.com>, linux-block@...r.kernel.org
Cc:     gjoyce@...ux.vnet.ibm.com, jonathan.derrick@...ux.dev,
        linux-kernel@...r.kernel.org, Ondrej Kozina <okozina@...hat.com>
Subject: Re: [PATCH] block: Fix regression in sed-opal for a saved key.

On 10/3/23 4:02 AM, Milan Broz wrote:
> The commit 3bfeb61256643281ac4be5b8a57e9d9da3db4335
> introduced the use of keyring for sed-opal.
> 
> Unfortunately, there is also a possibility to save
> the Opal key used in opal_lock_unlock().
> 
> This patch switches the order of operation, so the cached
> key is used instead of failure for opal_get_key.
> 
> The problem was found by the cryptsetup Opal test recently
> added to the cryptsetup tree.

Greg, please review this.

-- 
Jens Axboe