linux-kernel - Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231004134106.7779c29c@kernel.org>
Date:   Wed, 4 Oct 2023 13:41:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc:     <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <michal.simek@....com>,
        <linux@...linux.org.uk>, <f.fainelli@...il.com>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <git@....com>,
        "Sarath Babu Naidu Gaddam" <sarath.babu.naidu.gaddam@....com>
Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
 dmaengine support

On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:
>   */
> -static int axienet_open(struct net_device *ndev)
> +

nit: spurious new line

> +static inline int axienet_init_legacy_dma(struct net_device *ndev)

nit: no need for the inline, it has one caller and isn't on the fast
path