linux-kernel - Re: [PATCH 04/11] genpd: ti: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpEdFnJ5p+O2p-gr06mF9ug43Ss-=2uJeSVZzgrcTGzTg@mail.gmail.com>
Date:   Thu, 5 Oct 2023 00:24:21 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Julia Lawall <Julia.Lawall@...ia.fr>
Cc:     Nishanth Menon <nm@...com>, kernel-janitors@...r.kernel.org,
        Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/11] genpd: ti: add missing of_node_put

On Thu, 7 Sept 2023 at 11:55, Julia Lawall <Julia.Lawall@...ia.fr> wrote:
>
> for_each_node_with_property performs an of_node_get on
> each iteration, so a break out of the loop requires an
> of_node_put.
>
> This was done using the Coccinelle semantic patch
> iterators/for_each_child.cocci
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Applied for next (by amending the change to pmdomain instead of genpd), thanks!

Kind regards
Uffe

>
> ---
>  drivers/genpd/ti/ti_sci_pm_domains.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff -u -p a/drivers/genpd/ti/ti_sci_pm_domains.c b/drivers/genpd/ti/ti_sci_pm_domains.c
> --- a/drivers/genpd/ti/ti_sci_pm_domains.c
> +++ b/drivers/genpd/ti/ti_sci_pm_domains.c
> @@ -153,14 +153,18 @@ static int ti_sci_pm_domain_probe(struct
>                                         max_id = args.args[0];
>
>                                 pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
> -                               if (!pd)
> +                               if (!pd) {
> +                                       of_node_put(np);
>                                         return -ENOMEM;
> +                               }
>
>                                 pd->pd.name = devm_kasprintf(dev, GFP_KERNEL,
>                                                              "pd:%d",
>                                                              args.args[0]);
> -                               if (!pd->pd.name)
> +                               if (!pd->pd.name) {
> +                                       of_node_put(np);
>                                         return -ENOMEM;
> +                               }
>
>                                 pd->pd.power_off = ti_sci_pd_power_off;
>                                 pd->pd.power_on = ti_sci_pd_power_on;
>