linux-kernel - Re: [PATCH] pmdomain: imx: scu-pd: correct DMA2 channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpbq3aH6n5p5M1e9ye8DwDr-uZqdLYbCND1N5gVL-0tXA@mail.gmail.com>
Date:   Thu, 5 Oct 2023 00:33:49 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, Peng Fan <peng.fan@....com>,
        Dong Aisheng <Aisheng.dong@....com>
Subject: Re: [PATCH] pmdomain: imx: scu-pd: correct DMA2 channel

On Sun, 1 Oct 2023 at 14:34, Peng Fan (OSS) <peng.fan@....nxp.com> wrote:
>
> From: Peng Fan <peng.fan@....com>
>
> Per "dt-bindings/firmware/imx/rsrc.h", `IMX_SC_R_DMA_2_CH0 + 5` not
> equals to IMX_SC_R_DMA_2_CH5, so there should be two entries in
> imx8qxp_scu_pd_ranges, otherwise the imx_scu_add_pm_domain may filter
> out wrong power domains.
>
> Fixes: 927b7d15dcf2 ("genpd: imx: scu-pd: enlarge PD range")
> Reported-by: Dong Aisheng <Aisheng.dong@....com>
> Signed-off-by: Peng Fan <peng.fan@....com>

Applied for fixes, thanks!

Kind regards
Uffe

> ---
>  drivers/pmdomain/imx/scu-pd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/imx/scu-pd.c b/drivers/pmdomain/imx/scu-pd.c
> index 2f693b67ddb4..891c1d925a9d 100644
> --- a/drivers/pmdomain/imx/scu-pd.c
> +++ b/drivers/pmdomain/imx/scu-pd.c
> @@ -150,7 +150,8 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
>         { "mclk-out-1", IMX_SC_R_MCLK_OUT_1, 1, false, 0 },
>         { "dma0-ch", IMX_SC_R_DMA_0_CH0, 32, true, 0 },
>         { "dma1-ch", IMX_SC_R_DMA_1_CH0, 16, true, 0 },
> -       { "dma2-ch", IMX_SC_R_DMA_2_CH0, 32, true, 0 },
> +       { "dma2-ch-0", IMX_SC_R_DMA_2_CH0, 5, true, 0 },
> +       { "dma2-ch-1", IMX_SC_R_DMA_2_CH5, 27, true, 0 },
>         { "dma3-ch", IMX_SC_R_DMA_3_CH0, 32, true, 0 },
>         { "asrc0", IMX_SC_R_ASRC_0, 1, false, 0 },
>         { "asrc1", IMX_SC_R_ASRC_1, 1, false, 0 },
> --
> 2.37.1
>