[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHCN7xKrriTPaRMJ-r86cSgFDUUP1At08imLBr_zEP0g3fga_g@mail.gmail.com>
Date: Wed, 4 Oct 2023 18:41:09 -0500
From: Adam Ford <aford173@...il.com>
To: Hugues Fruchet <hugues.fruchet@...s.st.com>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
Philipp Zabel <p.zabel@...gutronix.de>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
linux-stm32@...md-mailman.stormreply.com,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Subject: Re: [PATCH 3/7] dt-bindings: media: Document STM32MP25 VENC video encoder
On Wed, Oct 4, 2023 at 4:16 AM Hugues Fruchet
<hugues.fruchet@...s.st.com> wrote:
>
> Add STM32MP25 VENC video encoder bindings.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@...s.st.com>
> ---
> .../bindings/media/st,stm32mp25-venc.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml
> new file mode 100644
> index 000000000000..c69e0a34f675
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/st,stm32mp25-venc.yaml#
Can this dt-binding be made more generic, like something like
hantro-h1 or VC8000NanoE?
I think there will be more boards that may incorporate the Hantro-H1
or a VC8000 in the future, because I don't think this IP is unique to
the STM32MP25.
adam
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32MP25 VENC video encoder
> +
> +maintainers:
> + - Hugues Fruchet <hugues.fruchet@...s.st.com>
> +
> +description:
> + The STMicroelectronics STM32MP25 SOCs embeds a VENC video hardware encoder
> + peripheral based on Verisilicon VC8000NanoE IP (former Hantro H1).
> +
> +properties:
> + compatible:
> + const: st,stm32mp25-venc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + venc: venc@...e0000 {
> + compatible = "st,stm32mp25-venc";
> + reg = <0x580e0000 0x800>;
> + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "venc";
Is the interrupt-names needed if there is only one?
> + clocks = <&ck_icn_p_venc>;
> + clock-names = "venc-clk";
Same thing for the clock. if there is only one clock, doe they need names?
adam
> + };
> --
> 2.25.1
>
Powered by blists - more mailing lists