[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <43b158b2-6958-4a2f-8b2d-c6f7d3b39dfb@linaro.org>
Date: Wed, 4 Oct 2023 08:45:30 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: niravkumar.l.rabara@...el.com, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Dinh Nguyen <dinguyen@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: altera: convert socfpga-system.txt to
yaml
On 04/10/2023 05:07, niravkumar.l.rabara@...el.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
>
> Convert socfpga-system.txt to altr,sys-mgr.yaml.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> ---
> .../bindings/arm/altera/altr,sys-mgr.yaml | 50 +++++++++++++++++++
> .../bindings/arm/altera/socfpga-system.txt | 25 ----------
> 2 files changed, 50 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/arm/altera/altr,sys-mgr.yaml
arm is only for top-level. What is this this device about? FPGA? SoC?
> delete mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-system.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/altera/altr,sys-mgr.yaml b/Documentation/devicetree/bindings/arm/altera/altr,sys-mgr.yaml
> new file mode 100644
> index 000000000000..8deb70aef664
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/altera/altr,sys-mgr.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/altera/altr,sys-mgr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera SOCFPGA System Manager
> +
> +maintainers:
> + - Dinh Nguyen <dinguyen@...nel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - description: Cyclone5/Arria5/Arria10
> + const: altr,sys-mgr
> + - description: Stratix10 SoC
> + items:
> + - const: altr,sys-mgr-s10
> + - const: altr,sys-mgr
That's not what old binding was saying. Please describe in the commit
msg differences from pure conversion.
> +
> + reg:
> + maxItems: 1
> +
> + cpu1-start-addr:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: CPU1 start address in hex
> +
> +required:
> + - compatible
> + - reg
> +
> +if:
Please keep it here under "allOf:". Will save you one re-indentation on
any new variant.
> + properties:
> + compatible:
> + contains:
> + const: altr,sys-mgr-s10
> +then:
> + properties:
> + cpu1-start-addr: false
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sysmgr@...08000 {
> + compatible = "altr,sys-mgr";
> + reg = <0xffd08000 0x1000>;
> + cpu1-start-addr = <0xffd080c4>;
> + };
Best regards,
Krzysztof
Powered by blists - more mailing lists