[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4bc021c1-0198-41a4-aa73-bf0cf0c0420a@linaro.org>
Date: Wed, 4 Oct 2023 08:57:52 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nitheesh Sekar <quic_nsekar@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org,
lpieralisi@...nel.org, kw@...ux.com, robh@...nel.org,
bhelgaas@...gle.com, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, vkoul@...nel.org, kishon@...nel.org,
mani@...nel.org, p.zabel@...gutronix.de, quic_srichara@...cinc.com,
quic_varada@...cinc.com, quic_ipkumar@...cinc.com,
linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-phy@...ts.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe
uniphy
On 03/10/2023 14:08, Nitheesh Sekar wrote:
> Document the Qualcomm UNIPHY PCIe 28LP present in IPQ5018.
>
> Signed-off-by: Nitheesh Sekar <quic_nsekar@...cinc.com>
Thank you for your patch. There is something to discuss/improve.
> ---
> .../bindings/phy/qcom,uniphy-pcie-28lp.yaml | 77 +++++++++++++++++++
> 1 file changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,uniphy-pcie-28lp.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,uniphy-pcie-28lp.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy-pcie-28lp.yaml
> new file mode 100644
> index 000000000000..6b2574f9532e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy-pcie-28lp.yaml
Filename should match compatibles and they do not use 28lp.
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/qcom,uniphy-pcie-28lp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm UNIPHY PCIe 28LP PHY driver
Driver as Linux driver? Drop. Describe the hardware instead.
> +
> +maintainers:
> + - Nitheesh Sekar <quic_nsekar@...cinc.com>
> + - Sricharan Ramabadhran <quic_srichara@...cinc.com>
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,ipq5018-uniphy-pcie-gen2x1
> + - qcom,ipq5018-uniphy-pcie-gen2x2
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: pipe_clk
Drop _clk... or even drop entire clock-names. Not needed for one entry.
> +
> + resets:
> + maxItems: 2
> +
> + reset-names:
> + items:
> + - const: phy
> + - const: phy_phy
These are absolutely terrible names. If you have third one, it would be
"phy_phy_phy"? Drop or provide something useful.
> +
> + "#phy-cells":
> + const: 0
> +
> + "#clock-cells":
> + const: 0
> +
> + clock-output-names:
> + maxItems: 1
Best regards,
Krzysztof
Powered by blists - more mailing lists