linux-kernel - Re: [RFC PATCH v2] mtd: nand: add support for ts72xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231004103835.55cccdc6@xps-13>
Date:   Wed, 4 Oct 2023 10:38:35 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org
Subject: Re: [RFC PATCH v2] mtd: nand: add support for ts72xx

Hi Nikita,

nikita.shubin@...uefel.me wrote on Wed,  4 Oct 2023 11:22:23 +0300:

> Technologic Systems has it's own nand controller implementation in CPLD.
> 
> Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> ---
> Changelog v2:
> - dropped check for READCACHE
> - reordered Makefile
> 
> Link: https://lore.kernel.org/linux-mtd/20230926132725.5d570e1b@xps-13/T/#md7e5e944a6a08e24f4f1e20068a49f94794ab945
> ---

[...]

> +static int ts72xx_nand_exec_op(struct nand_chip *chip,
> +			       const struct nand_operation *op, bool check_only)
> +{
> +	unsigned int i;
> +	int ret;
> +

Missing:

	if (check_only)
		return 0;

LGTM otherwise.

Thanks,
Miquèl