linux-kernel - RE: [PATCH 1/1] tty: n_gsm: Avoid sleeping during .write() whilst atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB5881526A2B8F27FE36C49134E0CBA@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date:   Wed, 4 Oct 2023 08:58:32 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Lee Jones <lee@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Fedor Pchelkin <pchelkin@...ras.ru>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "syzbot+5f47a8cea6a12b77a876@...kaller.appspotmail.com" 
        <syzbot+5f47a8cea6a12b77a876@...kaller.appspotmail.com>
Subject: RE: [PATCH 1/1] tty: n_gsm: Avoid sleeping during .write() whilst
 atomic

> So without actually looking into the code, can we just somehow disallow
> attaching this line discipline to a console (ban such a TIOCSETD) and be
> done with this issue? IOW disallow root to shoot their foot.

Probably possible by patching gsmld_open() if there is a function which can
check this based on a struct tty_struct * handle. That may, however,
introduce some cross references that are hard to maintain.

Best regards,
Daniel Starke