[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231004093323.GK1539@noisy.programming.kicks-ass.net>
Date: Wed, 4 Oct 2023 11:33:23 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: Zhang Qiao <zhangqiao22@...wei.com>, mingo@...hat.com,
juri.lelli@...hat.com, vincent.guittot@...aro.org,
dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Update comment of try_invoke_on_locked_down_task()
On Wed, Oct 04, 2023 at 11:31:26AM +0200, Ingo Molnar wrote:
>
> * Zhang Qiao <zhangqiao22@...wei.com> wrote:
>
> > Since commit 9b3c4ab3045e ("sched,rcu: Rework
> > try_invoke_on_locked_down_task()") renamed
> > try_invoke_on_locked_down_task() to task_call_func().
> > Now, update some comment about it.
> >
> > Signed-off-by: Zhang Qiao <zhangqiao22@...wei.com>
> > ---
> > kernel/sched/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 0d18c3969f90..540ac33ddb80 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -4186,7 +4186,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
> > * Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
> > * __schedule(). See the comment for smp_mb__after_spinlock().
> > *
> > - * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
> > + * A similar smb_rmb() lives in task_call_func().
>
> Except the matching smp_rmb() doesn't live in task_call_func() anymore, so
> you now turned a stale comment into a misleading one ...
It moved, *again*, it's now in __task_needs_rq_lock() :-)
Powered by blists - more mailing lists