[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f1e9f12d-5b40-0e08-3b67-94cfb0130bc5@quicinc.com>
Date: Wed, 4 Oct 2023 15:15:16 +0530
From: Devi Priya <quic_devipriy@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <lee@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<thierry.reding@...il.com>, <ndesaulniers@...gle.com>,
<trix@...hat.com>, <baruch@...s.co.il>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>
Subject: Re: [PATCH V13 4/4] arm64: dts: ipq6018: add pwm node
On 10/4/2023 3:13 PM, Krzysztof Kozlowski wrote:
> On 04/10/2023 11:04, Devi Priya wrote:
>> Describe the PWM block on IPQ6018.
>>
>> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
>> &pwm as child of &tcsr.
>>
>
> ...
>
>> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>>
>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index e59b9df96c7e..429ad7cb681c 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@...5000 {
>> };
>>
>> tcsr: syscon@...7000 {
>> - compatible = "qcom,tcsr-ipq6018", "syscon";
>> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>> reg = <0x0 0x01937000 0x0 0x21000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x01937000 0x21000>;
>
> Please put ranges just after reg.
Sure, okay
>
> With that:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Thank you!
Regards,
Devi Priya
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists