linux-kernel - Re: [PATCH 21/21] nvme: Support atomic writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231004113941.zx3jlgnt23vs453r@localhost>
Date:   Wed, 4 Oct 2023 13:39:41 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     John Garry <john.g.garry@...cle.com>
CC:     <axboe@...nel.dk>, <kbusch@...nel.org>, <hch@....de>,
        <sagi@...mberg.me>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <djwong@...nel.org>,
        <viro@...iv.linux.org.uk>, <brauner@...nel.org>,
        <chandan.babu@...cle.com>, <dchinner@...hat.com>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-nvme@...ts.infradead.org>, <linux-xfs@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <tytso@....edu>,
        <jbongio@...gle.com>, <linux-api@...r.kernel.org>,
        Alan Adamson <alan.adamson@...cle.com>, <p.raghav@...sung.com>
Subject: Re: [PATCH 21/21] nvme: Support atomic writes

> +++ b/drivers/nvme/host/core.c
> @@ -1926,6 +1926,35 @@ static void nvme_update_disk_info(struct gendisk *disk,
>  	blk_queue_io_min(disk->queue, phys_bs);
>  	blk_queue_io_opt(disk->queue, io_opt);
>  
> +	atomic_bs = rounddown_pow_of_two(atomic_bs);
> +	if (id->nsfeat & NVME_NS_FEAT_ATOMICS && id->nawupf) {
> +		if (id->nabo) {
> +			dev_err(ns->ctrl->device, "Support atomic NABO=%x\n",
> +				id->nabo);
> +		} else {
> +			u32 boundary = 0;
> +
> +			if (le16_to_cpu(id->nabspf))
> +				boundary = (le16_to_cpu(id->nabspf) + 1) * bs;
> +
> +			if (is_power_of_2(boundary) || !boundary) {
> +				blk_queue_atomic_write_max_bytes(disk->queue, atomic_bs);
> +				blk_queue_atomic_write_unit_min_sectors(disk->queue, 1);
> +				blk_queue_atomic_write_unit_max_sectors(disk->queue,
> +									atomic_bs / bs);
blk_queue_atomic_write_unit_[min| max]_sectors expects sectors (512 bytes unit)
as input but no conversion is done here from device logical block size
to SECTORs.
> +				blk_queue_atomic_write_boundary_bytes(disk->queue, boundary);
> +			} else {
> +				dev_err(ns->ctrl->device, "Unsupported atomic boundary=0x%x\n",
> +					boundary);
> +			}
>