linux-kernel - Re: Regression: devcoredump patch broke Realtek usb bluetooth adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231004114609.dca6ebtmx37fsx5l@box.shutemov.name>
Date:   Wed, 4 Oct 2023 14:46:09 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Max Chou <max.chou@...ltek.com>
Cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Hilda Wu <hildawu@...ltek.com>,
        "alex_lu@...lsil.com.cn" <alex_lu@...lsil.com.cn>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Juerg Haefliger <juerg.haefliger@...onical.com>,
        Linux Bluetooth <linux-bluetooth@...r.kernel.org>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Linux Regressions <regressions@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Regression: devcoredump patch broke Realtek usb bluetooth adapter

On Wed, Oct 04, 2023 at 07:28:45AM +0000, Max Chou wrote:
> Hi! Kirill,
> I guess the root cause is as below.
> ===
> static int btrtl_register_devcoredump_support(struct hci_dev *hdev)
> {
>         int err;
> 
>         err = hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
> 
>         return err;
> }
> ===
> If CONFIG_DEV_COREDUMP is not enabled, it would return -EOPNOTSUPP for hci_devcd_register().
> Unfortunately, btrtl_register_devcoredump_support() will return it. 
> Finally, -EOPNOSTUPP will be returned for btrtl_setup_realtek().
> 
> Could you have the following workaround for the root cause checked?
> Please share dmesg as well. Thanks,

Yes. It works and I see 

[    3.640539] Bluetooth: hci0: RTL: btrtl_register_devcoredump_support(): err = -95

in dmesg. -EOPNOTSUPP indeed.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov