linux-kernel - Re: [PATCH v2 1/6] firmware: xilinx: Update firmware call interface to support additional arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023100445-rising-brittle-fe69@gregkh>
Date:   Wed, 4 Oct 2023 14:14:18 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jay Buddhabhatti <jay.buddhabhatti@....com>
Cc:     michal.simek@....com, tanmay.shah@....com,
        nava.kishore.manne@....com, ben.levinsky@....com, robh@...nel.org,
        dhaval.r.shah@....com, marex@...x.de, izhar.ameer.shaikh@....com,
        arnd@...db.de, ruanjinjie@...wei.com, mathieu.poirier@...aro.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/6] firmware: xilinx: Update firmware call interface
 to support additional arg

On Wed, Oct 04, 2023 at 02:41:11AM -0700, Jay Buddhabhatti wrote:
>  int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 arg0, u32 arg1,
> -			u32 arg2, u32 arg3, u32 *ret_payload)
> +			u32 arg2, u32 arg3, u32 arg4,
> +			u32 *ret_payload)

You do have 100 columns to use now, why wrap?

Same for other places you did this.

thanks,

greg k-h